At the time of his election to Parliament, Edwards was described as a schoolmaster who had served four years in the Army during the First World War, reaching the rank of Major and seeing much active service. He was first elected to Parliament in the 1918 general election for the Welsh constituency of Aberavon. He served only one term in Parliament before being defeated at the 1922 general election. Ramsay MacDonald, who served as Leader of the Labour Party and Prime Minister, replaced him as Aberavon's MP. Edwards died in 1960 aged 77.
Edwards was born at Llanbardarn, near Aberystwyth, the son of the Reverend James Edwards and his wife Rachel (née Jones). When he was still young the family moved to his mother's home town of Neath  and he was educated at the British and Intermediate Schools in the town. He later went to University College of Wales, Aberystwyth and the University of London. In 1932, he married Gwen Bryan and they had two sons and a daughter.
During the First World War, Edwards joined the Royal Welch Fusiliers earning the Distinguished Service Order in 1918 and being twice mentioned in despatches. According to one source he attained the rank of Lieutenant-Colonel. Edwards also trained for the law and in 1921 he was called to the Bar at Gray's Inn.
After his defeat at Aberavon in 1922,Edwards sought re-election to the House of Commons as an Independent Liberal for the University of Wales seat at the 1923 general election but in a tight contest, with three candidates each getting about one third of the vote, he finished bottom of the poll. He did not stand for Parliament again.
Edwards was appointed a High Sheriff of Cardinganshire in 1942. He also served as a member of the Court of the University of Wales and the Court and Council of the University College of Wales at Aberystwyth.
Edwards took an active interest in Welsh drama and in 1925 he published a book, The Call of the Sea. He also published a number of articles in law journals. He also wrote a biography of his father, the Reverend James Edwards, under the title Edwards Castellnedd.